[PATCH 1/2] hwspinlock/omap: enable module before reading SYSSTATUS register

Hi Ohad,

On 07/24/2014 08:45 AM, Ohad Ben-Cohen wrote:

Hi Suman,

On Thu, Jul 3, 2014 at 2:00 AM, Suman Anna [off-list ref] wrote:

quoted

The number of hwspinlocks are determined based on the value read
from the IP block's SYSSTATUS register. However, the module may
not be enabled and clocked, and the read may result in a bus error.

This particular issue is seen rather easily on AM33XX, since the
module wakeup is software controlled, and it is disabled out of
reset. Make sure the module is enabled and clocked before reading
the SYSSTATUS register.

Signed-off-by: Suman Anna <redacted>

...

quoted

+       /*
+        * runtime PM will make sure the clock of this module is
+        * enabled again iff at least one lock is requested
+        */
+       ret = pm_runtime_put_sync(&pdev->dev);

Is there a specific reason for using the put_sync variant here? If
not, let's just use the regular put().

There was no particular reason, you can change it.

Let me know, and I can do the change while applying these two patches.

Sure, thanks.

regards
Suman