Thread (5 messages) 5 messages, 3 authors, 2014-07-04
STALE4470d REVIEWED: 1 (0M)

1 review trailer.

[PATCH] pinctrl: sunxi: Fix multi bank interrupt support in gpio_to_irq

From: Maxime Ripard <hidden>
Date: 2014-07-04 07:03:55

Hi,

On Tue, Jul 01, 2014 at 12:04:59AM +0800, Chen-Yu Tsai wrote:
When mapping the interrupts, the gpio_to_irq function did not consider
the bank number of the gpio pin in question, only the offset or the
interrupt number in the bank. As a result, requests for interrupts in
the later banks get mapped to the first bank.

This issue was discovered while enabling mmc on the new sun8i platform.
The tablet I have uses a pin/interrupt from the second bank to do mmc
card detection. Tested on this very device with register inspection and
actual mmc card insertion/removal.

Signed-off-by: Chen-Yu Tsai <redacted>
Acked-by: Maxime Ripard <redacted>

Linus, could this be merged as a fix for 3.16?

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140704/94b1554b/attachment-0001.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help