Thread (13 messages) 13 messages, 4 authors, 2014-07-07

[PATCHv2 5/5] mmc: dw_mmc: replace "disable-wp" from slot's quirk to host's quirk

flat view

From: jh80.chung@samsung.com (Jaehoon Chung)
Date: 2014-07-07 11:00:14
Also in: linux-devicetree, linux-mmc, linux-samsung-soc

Hi, Seungwon.

On 07/07/2014 06:19 PM, Seungwon Jeon wrote:
Sorry for late review.
Never mind. :)
If you're in progress for next, please consider it.

On Mon, June 30, 2014, Jaehoon Chung wrote:
quoted
Replaced the "disable-wp" into host's quirks.
(Because the slot-node is removed at dt-file.)

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/mmc/host/dw_mmc.c |   13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 1ac227c..6c5d696 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -994,10 +994,11 @@ static int dw_mci_get_ro(struct mmc_host *mmc)
 {
 	int read_only;
 	struct dw_mci_slot *slot = mmc_priv(mmc);
+	struct dw_mci_board *brd = slot->host->pdata;
 	int gpio_ro = mmc_gpio_get_ro(mmc);

 	/* Use platform get_ro function, else try on board write protect */
-	if (slot->quirks & DW_MCI_SLOT_QUIRK_NO_WRITE_PROTECT)
It would be better to use host->quirks instead of brd->quirks
It's finally updated with host->pdata->quirks on probing.
It's reasonable, i will fix it and resend.

Best Regards,
Jaehoon Chung
Thanks,
Seungwon Jeon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help