On 2014?06?30? 18:00, Mark Rutland wrote:

On Mon, Jun 30, 2014 at 09:03:28AM +0100, Zhou Wang wrote:

quoted

Signed-off-by: Zhou Wang <redacted>
---
  drivers/mtd/nand/Kconfig     |    5 +
  drivers/mtd/nand/Makefile    |    1 +
  drivers/mtd/nand/hisi_nand.c |  847 ++++++++++++++++++++++++++++++++++++++++++
  3 files changed, 853 insertions(+)
  create mode 100644 drivers/mtd/nand/hisi_nand.c

[...]

quoted

+struct hinfc_host {
+       struct nand_chip        *chip;
+       struct mtd_info         *mtd;
+       struct device           *dev;
+       void __iomem            *iobase;
+       struct completion       cmd_complete;
+       unsigned int            offset;
+       unsigned int            command;
+       int                     chipselect;
+       unsigned int            addr_cycle;
+       unsigned int            addr_value[2];
+       unsigned int            cache_addr_value[2];
+       char                    *buffer;
+       dma_addr_t              dma_buffer;
+       dma_addr_t              dma_oob;
+       int                     version;
+       unsigned int            ecc_bits;
+       unsigned int            irq_status; /* interrupt status */
+
+       int (*send_cmd_pageprog)(struct hinfc_host *host);
+       int (*send_cmd_status)(struct hinfc_host *host);
+       int (*send_cmd_readstart)(struct hinfc_host *host);
+       int (*send_cmd_erase)(struct hinfc_host *host);
+       int (*send_cmd_readid)(struct hinfc_host *host);
+       int (*send_cmd_reset)(struct hinfc_host *host, int chipselect);
+};

[...]

quoted

+static int hisi_nfc_probe(struct platform_device *pdev)
+{
+       int ret = 0, irq, buswidth, flag, max_chips = HINFC504_MAX_CHIP;
+       struct device *dev = &pdev->dev;
+       struct hinfc_host *host;
+       struct nand_chip  *chip;
+       struct mtd_info   *mtd;
+       struct resource   *res;
+       struct device_node *np = dev->of_node;
+       struct mtd_part_parser_data ppdata;
+
+       host = devm_kzalloc(dev, sizeof(*host) + sizeof(*chip) + sizeof(*mtd),
+                       GFP_KERNEL);
+       if (!host)
+               return -ENOMEM;
+       host->dev = dev;
+
+       platform_set_drvdata(pdev, host);
+       chip = (struct nand_chip *)&host[1];
+       mtd  = (struct mtd_info *)&chip[1];

Why not embed the whole struct rather than pointers? Then you can
allocate just the host and extract pointers to the chip and mtd sub
structures.

Thanks,
Mark.

I will change this as your comment, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel