[PATCH v3 4/4] ARM: dts: Add exynos5250-spring device tree

Hi,

Am 31.07.2014 11:49, schrieb Ajay kumar:

On Thu, Jul 31, 2014 at 2:56 PM, Andreas F?rber [off-list ref] wrote:

quoted

Am 30.07.2014 15:50, schrieb Andreas F?rber:

quoted

diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts
new file mode 100644
index 000000000000..bcca892bf2ff
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5250-spring.dts

[...]

quoted

+&pinctrl_0 {
+     dp_hpd_gpio: dp-hpd-gpio {
+             samsung,pins = "gpc3-0";
+             samsung,pin-function = <1>;

Not sure where this 1 came from... Both Ajay and my 3.8 DT have 0.

Right, this should be 0.

quoted

quoted

+             samsung,pin-pud = <3>;
+             samsung,pin-drv = <0>;
+     };

Seeing that Ajay called this node dp-hdp, it should probably be an override?

dp_hpd should be enough. I will keep the same name for peach boards.
dp_hpd: dp-hpd {
.
.
.
};

Apart from my own set of typos, I see that you proposed dp-hpd whereas
-pinctrl.dtsi has dp_hpd (dash vs. underscore). My question is, can we
override the pinctrl one instead of adding a new one, or do they need to
coexist?

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg