Thread (24 messages) 24 messages, 4 authors, 2014-07-31

[PATCH v4 3/5] x86: Split syscall_trace_enter into two phases

From: oleg@redhat.com (Oleg Nesterov)
Date: 2014-07-29 19:28:15
Also in: linux-arch, linux-mips, lkml

On 07/28, Andy Lutomirski wrote:
quoted hunk ↗ jump to hunk
+long syscall_trace_enter_phase2(struct pt_regs *regs, u32 arch,
+				unsigned long phase1_result)
+{
+	long ret = 0;
+	u32 work = ACCESS_ONCE(current_thread_info()->flags) &
+		_TIF_WORK_SYSCALL_ENTRY;
+
+	BUG_ON(regs != task_pt_regs(current));
 
 	/*
 	 * If we stepped into a sysenter/syscall insn, it trapped in
@@ -1463,17 +1569,20 @@ long syscall_trace_enter(struct pt_regs *regs)
 	 * do_debug() and we need to set it again to restore the user
 	 * state.  If we entered on the slow path, TF was already set.
 	 */
-	if (test_thread_flag(TIF_SINGLESTEP))
+	if (work & _TIF_SINGLESTEP)
 		regs->flags |= X86_EFLAGS_TF;
This is minor, I won't argue, but this can be moved into phase1(), afaics.

Oleg.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help