[PATCH 2/7] dmaengine: omap-dma: complete the transfer on terminate_all
From: bigeasy@linutronix.de (Sebastian Andrzej Siewior)
Date: 2014-07-29 19:06:23
Also in:
linux-omap, linux-serial, lkml
On 07/29/2014 08:58 PM, Sebastian Andrzej Siewior wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c index b19f04f..81ede01 100644 --- a/drivers/dma/omap-dma.c +++ b/drivers/dma/omap-dma.c@@ -970,6 +970,12 @@ static int omap_dma_terminate_all(struct omap_chan *c) /* Prevent this channel being scheduled */ spin_lock(&d->lock); + if (!c->desc && !list_empty(&c->node)) { + struct virt_dma_desc *vd = vchan_next_desc(&c->vc); + + if (vd) + dma_cookie_complete(&vd->tx); + }
Why is start of the transfer deferred to the tasklet unless it is a periodic transfer? Couldn't it be started right away?
list_del_init(&c->node); spin_unlock(&d->lock);
Sebastian