Thread (14 messages) flat view 14 messages, 2 authors, 2014-09-23

[PATCH 1/2] remoteproc: use a flag to detect the presence of IOMMU

From: Ohad Ben-Cohen <hidden>
Date: 2014-07-29 10:57:35
Also in: linux-omap, lkml

Hi Suman,

On Tue, Jul 8, 2014 at 7:22 PM, Suman Anna [off-list ref] wrote:
The remoteproc driver core currently relies on iommu_present() on
the bus the device is on, to perform MMU management. However, this
logic doesn't scale for multi-arch, especially for processors that
do not have an IOMMU.
Is there a specific hw/scenario where you need this? Can you please
provide more details about it?

Ideally we should add them to the commit log as well.
The individual platform implementations are required to set this
flag appropriately. The default setting is to not have an MMU.
Let's explicitly set the default please so this would be clear for
users reading the code.
Cc: Sjur Br?ndeland <redacted>
Sjur is no longer with STE, so no point in cc'ing his old email address.
+       /*
+        * All existing OMAP IPU and DSP processors do have an MMU, and
+        * are expected to use MMU, so this statement suffices.
+        * XXX: Replace this logic if and when a need arises.
The last XXX comment is always true for any kernel code, so I'd drop it.

Thanks,
Ohad.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help