On Thu, Jul 24, 2014 at 04:44:20PM -0700, Andrew Morton wrote:

On Thu, 24 Jul 2014 14:13:15 +0200 Maxime Ripard [off-list ref] wrote:

quoted

On Thu, Jul 17, 2014 at 09:46:14PM +0200, Maxime Ripard wrote:

quoted

Hi,

This patchset adds support for the DMA controller found in the
Allwinner A31 and A23 SoCs.

This has been tested using the newly introduced SPI driver on an A31
EVK. Support for DMA-driven SPI transfers will be the subject of
another patch serie.

This has been around for around 5 monthes now, and didn't get any
review but nitpicks for three versions, so I feel like it could be
merged quite quickly.

Ok, so, who should I bribe to get this merged?

Turns out I'm easily bribed.  The code looks pretty clean and simple
and is refreshingly free of comments, which only confuse people anyway.

Sorry for the delay, I will get this done today and merge to slave-dmaengine
next

I think we could do this as a single patch - is there any benefit to
splitting it apart like this?

Typically DT bindings are sent as aseprate patch and review independent of
teh driver. Though not many from DT-list have looked up slowing down patches

The combinations of spin_lock()/spin_lock_irq() and spin_lock_irqsave()
are a bit scary - it's easy to get these optimisations wrong.  Has it
been thoroughly tested with lockdep enabled?

Since the dma is handled in the irq, iut is actaully essential to have
irqsave versions for dmaenegine driver

Thanks
-- 
~Vinod