Thread (23 messages) 23 messages, 5 authors, 2014-08-20

[PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

From: peter.griffin@linaro.org (Peter Griffin)
Date: 2014-07-22 09:38:23
Also in: linux-devicetree, linux-omap, lkml

Hi Jingoo,

Sorry for the delay in replying. Thanks for reviewing, 
see my comments inline below: -

<snip>
quoted
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/slab.h>
+#include <linux/interrupt.h>
+#include <linux/platform_device.h>
+#include <linux/ioport.h>
+#include <linux/io.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
+#include <linux/mfd/syscon.h>
+#include <linux/delay.h>
+#include <linux/regmap.h>
+#include <linux/reset.h>
Would you re-order these headers alphabetically?
It enhances the readability.
Ok fixed in V3
quoted
+
+	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "reg-glue");
+	if (!res)
+		return -ENXIO;
+
+	dwc3_data->glue_base = devm_request_and_ioremap(dev, res);
Please don't use devm_request_and_ioremap() any more. It was deprecated
and will be removed from 3.17-rc1.

Please, use devm_ioremap_resource() instead.
Ok changed over to use devm_ioremap_resource in V3.
+	dwc3_data->glue_base = devm_ioremap_resource(dev, res);
+	if (IS_ERR(dwc3_data->glue_base))
+		return PTR_ERR(dwc3_data->glue_base);
quoted
+	if (!dwc3_data->glue_base)
+		return -EADDRNOTAVAIL;
+
<snip>
quoted
+
+static const struct dev_pm_ops st_dwc3_dev_pm_ops = {
+	SET_SYSTEM_SLEEP_PM_OPS(st_dwc3_suspend, st_dwc3_resume)
+};
+
+static struct of_device_id st_dwc3_match[] = {
Please add 'const' as below. This is because all OF functions
handle of_device_id as const.

static const struct of_device_id st_dwc3_match[] = {
Ok, fixed in V3
quoted
+	{ .compatible = "st,stih407-dwc3" },
+	{ /* sentinel */ },
+};
+
+MODULE_DEVICE_TABLE(of, st_dwc3_match);
+
+static struct platform_driver st_dwc3_driver = {
+	.probe = st_dwc3_probe,
+	.remove = st_dwc3_remove,
+	.driver = {
+		.name = "usb-st-dwc3",
+		.owner = THIS_MODULE,
+		.of_match_table = of_match_ptr(st_dwc3_match),
You already use OF dependency as below. So, of_match_ptr() is
NOT necessary.

+config USB_DWC3_ST
+	tristate "STMicroelectronics Platforms"
+	depends on ARCH_STI && OF

Please remove of_match_ptr() as below.

+		.of_match_table = st_dwc3_match,
Ok fixed in V3

regards,

Peter.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help