Thread (22 messages) 22 messages, 7 authors, 2014-07-21

[PATCH v10 3/8] ata: libahci_platform: move port_map parameters into the AHCI structure

From: Antoine Ténart <hidden>
Date: 2014-07-21 09:02:20
Also in: linux-devicetree, linux-ide, lkml

Hi,

On Fri, Jul 18, 2014 at 09:47:30AM -0400, Tejun Heo wrote:
On Fri, Jul 18, 2014 at 02:30:02PM +0200, Antoine T?nart wrote:
quoted
@@ -321,6 +321,8 @@ struct ahci_host_priv {
 	u32			cap;		/* cap to use */
 	u32			cap2;		/* cap2 to use */
 	u32			port_map;	/* port map to use */
+	u32			force_port_map;	/* force port map */
+	u32			mask_port_map;	/* mask out particular bits */
So, ->flags and ->force/mask_port_map are the only input ones, right?
Can we collect them to one spot and label them as such?
Yes. So you want a comment about this in the header?

Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help