[PATCH v4 1/3] soc: devicetree: bindings: Add Qualcomm RPM DT binding
From: pramod gurav <hidden>
Date: 2014-07-16 10:06:16
Also in:
linux-arm-msm, linux-devicetree, lkml
Hi Bjorn, RPM breaks on IFC6410 without entry for 'qcom.ipc' node. Please find my observations below. On Wed, Jul 16, 2014 at 4:30 AM, Bjorn Andersson [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Add binding for the Qualcomm Resource Power Manager (RPM) found in 8660, 8960 and 8064 based devices. The binding currently describes the rpm itself and the regulator subnodes. Signed-off-by: Bjorn Andersson <redacted> --- .../devicetree/bindings/soc/qcom/qcom,rpm.txt | 263 +++++++++++++++++++++ include/dt-bindings/soc/qcom,rpm.h | 142 +++++++++++ 2 files changed, 405 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,rpm.txt create mode 100644 include/dt-bindings/soc/qcom,rpm.hdiff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,rpm.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,rpm.txt new file mode 100644 index 0000000..ac98ffc --- /dev/null +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,rpm.txt@@ -0,0 +1,263 @@ +Qualcomm Resource Power Manager (RPM) +
. [snip] .
+- #size-cells: + Usage: required + Value type: <u32> + Definition: must be 0 + +- qcom,ipc: + Usage: required + Value type: <prop-encoded-array> + Definition: three entries specifying: + - phandle to a syscon node representing the apcs registers + - u32 representing offset to the register within the syscon + - u32 representing the ipc bit within the register
Was testing your patch on IFC6410 and looks like its breaking because this node support not being in IFC DTs. I was using the earlier versions of these patches and things were working. Please let me know the changes needed in IFC6410 DT for qcom,ipc.
+ + += SUBDEVICES +
. [snip] .
+ Definition: resource as defined in <dt-bindings/soc/qcom/qcom,rpm.h>
+
+
+= EXAMPLE
+
+ #include <dt-bindings/soc/qcom,rpm.h>
+
+ rpm at 108000 {
+ compatible = "qcom,rpm-msm8960";
+ reg = <0x108000 0x1000>;
+ qcom,ipc = <&apcs 0x8 2>;Tried adding this but there is no reference to 'apcs' registers itself in any dts. Without these changes rpm breaks hence not able to test SATA which needs rpm.
+ + interrupts = <0 19 0>, <0 21 0>, <0 22 0>; + interrupt-names = "ack", "err", "wakeup"; +
. [snip] .
+ +#endif -- 1.8.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
-- Thanks and Regards Pramod