[PATCH v9 11/11] seccomp: implement SECCOMP_FILTER_FLAG_TSYNC

From
Oleg Nesterov <oleg@redhat.com>
Date
2014-07-09 18:07:31
Also in
linux-api, linux-arch, linux-mips, lkml
Reply to
Kees Cook, 2014-06-27
First of all, sorry for delay ;)

So far I quickly glanced at this series and everything look fine, but
I am confused by the signal_group_exit() check,

On 06/27, Kees Cook wrote:
To make sure that de_thread() is actually able
to kill other threads during an exec, any sighand holders need to check
if they've been scheduled to be killed, and to give up on their work.
Probably this connects to that check below? I can't understand this...
quoted hunk ↗ jump to hunk
+	/*
+	 * Make sure we cannot change seccomp or nnp state via TSYNC
+	 * while another thread is in the middle of calling exec.
+	 */
+	if (flags & SECCOMP_FILTER_FLAG_TSYNC &&
+	    mutex_lock_killable(&current->signal->cred_guard_mutex))
+		goto out_free;
-EINVAL looks a bit confusing in this case, but this is cosemtic because
userspace won't see this error-code anyway.
quoted hunk ↗ jump to hunk
 	spin_lock_irq(&current->sighand->siglock);
+	if (unlikely(signal_group_exit(current->signal))) {
+		/* If thread is dying, return to process the signal. */
OK, this doesn't hurt, but why?

You could check __fatal_signal_pending() with the same effect. And since
we hold this mutex, exec (de_thread) can be the source of that SIGKILL.
We take this mutex specially to avoid the race with exec.

So why do we need to abort if we race with kill() or exit_grouo() ?

Oleg.
Thread (23 messages) 23 messages, 2 authors, last reply 2014-07-10
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help