[PATCH V8 1/6] power: reset: Add generic SYSCON register mapped reset
From: linux@roeck-us.net (Guenter Roeck)
Date: 2014-07-09 03:54:24
Also in:
linux-devicetree, lkml
On 07/08/2014 07:15 PM, Feng Kan wrote:
quoted hunk ↗ jump to hunk
Add a generic SYSCON register mapped reset mechanism. Signed-off-by: Feng Kan <redacted> --- drivers/power/reset/Kconfig | 6 +++ drivers/power/reset/Makefile | 1 + drivers/power/reset/syscon-reboot.c | 91 +++++++++++++++++++++++++++++++++++++ 3 files changed, 98 insertions(+) create mode 100644 drivers/power/reset/syscon-reboot.cdiff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig index bdcf517..5877b38 100644 --- a/drivers/power/reset/Kconfig +++ b/drivers/power/reset/Kconfig@@ -80,3 +80,9 @@ config POWER_RESET_KEYSTONE help Reboot support for the KEYSTONE SoCs. +config POWER_RESET_SYSCON + bool "Generic SYSCON regmap reset driver" + depends on ARM || ARM64 || COMPILE_TEST
As written, this driver is really not generic but very arm specific. I don't think COMPILE_TEST is a good idea either, since arm_pm_restart is only defined for the arm architecture. Did you try compiling allmodconfig or allyesconfig for, say, x86_64 with this patch applied ? I think this might benefit from using [1], which would make it really generic. Guenter [1] http://www.spinics.net/lists/kernel/msg1780939.html