Thread (11 messages) 11 messages, 4 authors, 2014-07-17

[PATCH 6/6] arm: LLVMLinux: Use current_stack_pointer in unwind_backtrace

flat view
STALE4472d SUPERSEDED: 1 (0M)

From: behanw at converseincode.com <hidden>
Date: 2014-07-08 20:16:57
Also in: lkml
Subsystem: arm port, the rest · Maintainers: Russell King, Linus Torvalds

Revision v1 of 6 in this series; 1 review trailer.

Revisions (6)
  1. v1 current
  2. v2 [diff vs current]
  3. rfc [diff vs current]
  4. v2 [diff vs current]
  5. v3 [diff vs current]
  6. v4 [diff vs current]
From: Behan Webster <redacted>

Use the global current_stack_pointer to get the value of the stack pointer.
This change supports being able to compile the kernel with both gcc and clang.

Signed-off-by: Behan Webster <redacted>
Signed-off-by: Mark Charlebois <redacted>
Reviewed-by: Jan-Simon M??ller <redacted>
---
 arch/arm/kernel/unwind.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c
index e67682f..e20e8dc 100644
--- a/arch/arm/kernel/unwind.c
+++ b/arch/arm/kernel/unwind.c
@@ -471,7 +471,6 @@ int unwind_frame(struct stackframe *frame)
 void unwind_backtrace(struct pt_regs *regs, struct task_struct *tsk)
 {
 	struct stackframe frame;
-	register unsigned long current_sp asm ("sp");
 
 	pr_debug("%s(regs = %p tsk = %p)\n", __func__, regs, tsk);
 
@@ -487,7 +486,7 @@ void unwind_backtrace(struct pt_regs *regs, struct task_struct *tsk)
 			 ? regs->ARM_pc : regs->ARM_lr;
 	} else if (tsk == current) {
 		frame.fp = (unsigned long)__builtin_frame_address(0);
-		frame.sp = current_sp;
+		frame.sp = current_stack_pointer;
 		frame.lr = (unsigned long)__builtin_return_address(0);
 		frame.pc = (unsigned long)unwind_backtrace;
 	} else {
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help