[PATCH v6 3/4] ARM: EXYNOS: Add platform driver support for Exynos PMU
From: Tomasz Figa <hidden>
Date: 2014-07-08 14:32:14
Also in:
linux-samsung-soc, lkml
Hi Pankaj, Just one comment I already had to previous version. On 07.07.2014 07:19, Pankaj Dubey wrote: [snip]
quoted hunk ↗ jump to hunk
-static void exynos5_init_pmu(void) +static void exynos5_powerdown_conf(enum sys_powerdown mode) { unsigned int i; unsigned int tmp;@@ -382,51 +398,143 @@ void exynos_sys_powerdown_conf(enum sys_powerdown mode) { unsigned int i; - if (soc_is_exynos5250()) - exynos5_init_pmu(); + const struct exynos_pmu_data *pmu_data = pmu_context->pmu_data; + + if (!pmu_data) + return;
As I mentioned in my reply to previous version, I don't think there is any point in probing this driver when there is no pmu_data. AFAIK the generic syscon driver can take over in such case. After fixing this, feel free to add Reviewed-by: Tomasz Figa <redacted> -- Best regards, Tomasz