Thread (51 messages) flat view 51 messages, 6 authors, 2014-07-18

[PATCH v7 23/24] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock

From: Javier Martinez Canillas <hidden>
Date: 2014-07-07 06:57:53
Also in: linux-devicetree, linux-samsung-soc, lkml

Hello Krzysztof,

On 07/07/2014 08:06 AM, Krzysztof Kozlowski wrote:
On pi?, 2014-07-04 at 22:24 +0200, Javier Martinez Canillas wrote:
quoted
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.

Signed-off-by: Javier Martinez Canillas <redacted>
---

Changes since v6:
 - Remove unused code for SMPL and WTSR. Suggested by Krzysztof Kozlowski.
 - Don't spam the kernel log with unimportant info and just print for debug.
   Suggested by Krzysztof Kozlowski.
 - Use ARRAY_SIZE() instead of constant value. Suggested by Krzysztof Kozlowski.
 - Remove duplicated register setup. Suggested by Krzysztof Kozlowski.
 - Don't free/unregister managed allocated resources.
   Suggested by Krzysztof Kozlowski.
---
 drivers/rtc/Kconfig        |  10 +
 drivers/rtc/Makefile       |   1 +
 drivers/rtc/rtc-max77802.c | 508 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 519 insertions(+)
 create mode 100644 drivers/rtc/rtc-max77802.c

Reviewed-by: Krzysztof Kozlowski <redacted>
Thanks a lot for the review and for all the feedback you gave me on each version
of the series.
Best regards,
Krzysztof
Best regards,
Javier
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help