On Mon, 30 Jun 2014 18:07:49 -0700
Stephen Boyd [off-list ref] wrote:

quoted

quoted

 		if (clk->ops->enable) {
 			ret = clk->ops->enable(clk->hw);
 			if (ret) {

@@ -945,6 +965,7 @@ static int __clk_enable(struct clk *clk)
 				return ret;

It may make even more sense to add the tracepoints within the if
statement. Especially if you have a return on error.

Right. I was thinking that no "clk*_complete" event would mean there was
some error. Detecting that case is not so easy though. It may be better
to always have the completion event so we know how long hardware
operations take and so that error handling is simpler.

You could also have the event record the ret as well.

-- Steve