Thread (2 messages) 2 messages, 2 authors, 2014-06-13
DORMANTno replies

[PATCH v2] ARM: integrator: fix section mismatch problem

From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-06-13 13:32:58

On Wednesday 04 June 2014, Linus Walleij wrote:
This addresses a section mismatch problem in the IM-PD1
driver in the Integrator/AP.

The IM-PD1 contains a VIC interrupt controller and therefore
the driver calls vic_init_cascaded() which is marked __init as
irqchips are simply not hot-pluggable and specifically the VIC
is assumed to initiate only on boot.

However the module driver model of the Integrator LM bus
assumes that logic tile drivers can be probed at runtime. This
is not really the case for IM-PD1: these tiles are detected at
boot and they cannot be plugged into a running system. Before
this patch it is of course possible to modprobe them later.

By first forcing the IM-PD1 to bool we make sure this driver
gets compiled into the kernel, and we know it will be probed
only at boot time when the tiles are detected, so we can tag
its probe function __init_refok as we know it won't be called
after boot now, and the section mismatch problem goes away.

As a side effect, sysfs binding from userspace becomes
impossible, so we tag the driver to suppress the bind/unbind
sysfs attributes.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Russell King <redacted>
Signed-off-by: Linus Walleij <redacted>
---
ChangeLog v1->v2:
- Suppress sysfs bind/unbind for the IM-PD1

ARM SoC folks: please apply this directly if the solution seems
acceptable.
---
Applied to fixes branch, thanks.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help