Thread (7 messages) flat view 7 messages, 3 authors, 2014-06-10
STALE4471d

[PATCH 2/3] spi: s3c64xx: remove a compilation warning with an assignment

From: Sachin Kamat <hidden>
Date: 2014-06-10 09:45:03
Also in: linux-samsung-soc

Hi Naveen,

On Tue, Jun 10, 2014 at 2:30 PM, Naveen Krishna Chatradhi
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
This patch returns an integer error value instead of the
pointer.

"warning: return makes integer from pointer without a cast"

Signed-off-by: Naveen Krishna Chatradhi <redacted>
Cc: Javier Martinez Canillas <redacted>
Cc: Doug Anderson <dianders@chromium.org>
---
 drivers/spi/spi-s3c64xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 0c6013f..4594dde 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -817,7 +817,7 @@ static int s3c64xx_spi_setup(struct spi_device *spi)

        if (!spi->dev.of_node) {
                dev_err(&spi->dev, "device node not found\n");
-               return ERR_PTR(-EINVAL);
+               return -EINVAL;
Isn't this warning introduced by the previous patch (patch1/3)?
If so then this patch should be squashed into that.

-- 
Regards,
Sachin.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help