[PATCH v5 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes

Hello,

(2014/06/26 21:34), Sergei Shtylyov wrote:

Hello.

On 06/26/2014 07:37 AM, Yoshihiro Shimoda wrote:

quoted

quoted

quoted

quoted

From: Ben Dooks <redacted>

quoted

quoted

quoted

quoted

Add device nodes for the R8A7790 internal PCI bridge devices.

quoted

quoted

quoted

quoted

Signed-off-by: Ben Dooks <redacted>
Reviewed-by: Ian Molton <redacted>
[Sergei: added several properties to the PCI bridge nodes]
Signed-off-by: Sergei Shtylyov <redacted>

quoted

quoted

quoted

Thank you for the patch!

quoted

quoted

quoted

I tested this patch on my lager board and a usb memory, and it works.

quoted

quoted

quoted

Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

quoted

quoted

Thanks for testing. Just one quick question from my side: Which USB
port did you test?

quoted

I tested usb ch1 only...

    Note that channel #2 also should work.

Thank you for the point.
I tried to test usb ch2, and then it worked on my environment.

quoted

quoted

I somehow assumed that at least the majority of the USB ports on R-Car
Gen2 require a USB PHY device driver to work?

Thank you for the point.
About usb ch1, a USB PHY device driver doesn't need, I think.
But, about ch0 and ch2, I think that they should require a USB PHY device driver.

    Only channel #0 requires the PHY driver as the default routing for USB0 is 
to USBHS; channel #2 is routed to OHCI/EHCI by default.

I understood it.

Best regards,
Yoshihiro Shimoda

quoted

Best regards,
Yoshihiro Shimoda

WBR, Sergei