[PATCH v3 2/4] pinctrl: Add NVIDIA Tegra XUSB pad controller support
From: mperttunen@nvidia.com (Mikko Perttunen)
Date: 2014-06-17 11:20:25
Also in:
linux-devicetree, linux-tegra
Possibly related (same subject, not in this thread)
- 2014-06-17 · Re: [PATCH v3 2/4] pinctrl: Add NVIDIA Tegra XUSB pad controller support · Thierry Reding <hidden>
- 2014-06-16 · [PATCH v3 2/4] pinctrl: Add NVIDIA Tegra XUSB pad controller support · Thierry Reding <hidden>
This v3 breaks SATA; see below On 16/06/14 17:57, Thierry Reding wrote: ...
+ regval = padctl_readl(padctl, lane->offset); + + if (!value) + regval &= ~lane->iddq; + else + regval |= lane->iddq; + + padctl_writel(padctl, regval, lane->offset);
... The bits at at lane->iddq are actually IDDQ_DISABLE bits, so this is the wrong way around: having iddq = <0> in device tree leads to the device turning off. So either the DT property should be renamed or the branches of the if here should be switched around. v2 used the wrong variable so the else branch ended up being chosen each time, this also meant that SATA worked by chance. - Mikko