[PATCH V7 1/6] power: reset: Add generic SYSCON register mapped reset

On Thursday 26 June 2014 09:51:14 Feng Kan wrote:

quoted

quoted

diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index bdcf517..7035236 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig

@@ -80,3 +80,9 @@ config POWER_RESET_KEYSTONE
        help
          Reboot support for the KEYSTONE SoCs.

+config POWER_RESET_SYSCON
+       bool "Generic SYSCON regmap reset driver"
+       depends on ARCH_XGENE

If this is supposed to be generic, why are you depending on
a certain platform?

Yes, the problem was that it was breaking the x86 build.

You probably need to list the exact dependencies then, at least make
it depend on MFD_SYSCON and OF. We generally want all drivers to
build without warnings on all architectures. You can limit it to
(ARM || ARM64 || COMPILE_TEST) if you don't want it to show up on
x86 by default, but it should still be possible to build it when
COMPILE_TEST is set.

	Arnd