Thread (31 messages) flat view 31 messages, 5 authors, 2014-06-26

[PATCH v4 05/14] clk: Add generic driver for Maxim PMIC clocks

From: Javier Martinez Canillas <hidden>
Date: 2014-06-26 12:31:45
Also in: linux-devicetree, linux-samsung-soc, lkml

Hello Yadwinder,

Thanks a lot for your feedback.

On 06/26/2014 01:51 PM, Yadwinder Singh Brar wrote:
Hi Javier,

Sorry for jumping in late, but just one concern mentioned inline.

[ .. ]
quoted
+
+static unsigned long max_gen_recalc_rate(struct clk_hw *hw,
+                                        unsigned long parent_rate)
+{
+       return 32768;
+}
Isn't more safer(correct), if it check and return 0 when clk is
disabled(unprepared) ?
Makes sense to me. I'll add a if (__clk_is_enabled(hw->clk)) check in the next
version.
Regards,
Yadwinder
Best regards,
Javier
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help