Thread (7 messages) flat view 7 messages, 4 authors, 2014-06-26

[PATCH] clk: define and export __clk_get_debug for providers

From: Mike Turquette <hidden>
Date: 2014-06-25 18:24:01
Also in: linux-tegra, lkml

Quoting Arnd Bergmann (2014-06-25 11:07:37)
On Wednesday 25 June 2014 19:26:31 Peter De Schrijver wrote:
quoted
Define and export a new function __clk_get_debug which returns the debugfs
directory entry pointer. This can be used by clock providers to add debugfs
entries which are not related to a specific clock type. Examples include the
ability to measure the rate of a clock. It can also be used by modules to
create new debugfs entries. This is useful if you want to expose features
for testing which can potentially cause system instability such as allowing
to change a clock's rate from userspace.

Signed-off-by: Peter De Schrijver <redacted>
Just an idea, but would it be better to add a pair of functions to add/remove
debugfs files rather than exposing the dentry itself?
Arnd,

Yes, accessor functions are much better than exposing struct clk
internals.

Peter,

Just FYI, I'm trying to reverse the trend of prepending double
underscores for functions that are used by clock providers. That stuff
started out small and sort of grew out of control ;-)

Regards,
Mike
        Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help