Thread (11 messages) 11 messages, 5 authors, 2014-07-09

[PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

From: Mark Salter <hidden>
Date: 2014-06-25 16:41:29
Also in: linux-devicetree, lkml, netdev

On Tue, 2014-06-24 at 22:29 -0600, Dann Frazier wrote:
On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian
quoted
+       ring->desc_addr = dma_zalloc_coherent(dev, size, &ring->dma,
+                                             GFP_KERNEL);
Iyappan,
When testing this driver on a 3.16-rc2 base, I'm finding that
desc_addr gets assigned to NULL here, which results in an oops later
on (see below).

I wasn't seeing this before (3.15 base), so I'm guessing something
changed upstream, or in my config, to change this behavior. But it
does illuminate a place where we could maybe use some better error
handling (also see below).
https://lkml.org/lkml/2014/6/23/10
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help