Thread (13 messages) 13 messages, 6 authors, 2014-06-26

[PATCH v2] sched: Fix compiler warnings

From: linux@roeck-us.net (Guenter Roeck)
Date: 2014-06-25 15:04:00
Also in: linuxppc-dev, lkml

On 06/25/2014 07:49 AM, Uwe Kleine-K?nig wrote:
Hello Guenter,

On Wed, Jun 25, 2014 at 07:27:47AM -0700, Guenter Roeck wrote:
quoted
quoted
Maybe the author's intention was:

	static inline int cpu_corepower_flags(void) __attribute__((const));

?
This specifies that the function has no side effects and the return value
only depends on the (here non-existing) function arguments.
Possibly, but either I am missing something or this doesn't compile.
You need to do a separate declaration:

	static inline int cpu_corepower_flags(void) __attribute__((const));
	static inline int cpu_corepower_flags(void)
	{
		...
Actually turns out one can use __attribute_const__, and it is

	static inline int __attribute_const__ cpu_corepower_flags(void)

which turns out to be widely used.

I'll change that and resubmit after testing.

Guenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help