Thread (6 messages) 6 messages, 4 authors, 2014-05-27
STALE4416d

[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

From: Nicolas Pitre <hidden>
Date: 2014-05-22 17:55:16
Also in: linux-pm, linux-samsung-soc

On Thu, 22 May 2014, Daniel Lezcano wrote:
On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
quoted
This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
vexpress: Use wfi macro in platform_do_lowpower.")

Current Exynos CPU hotplug code includes a hardcoded WFI
instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
mode, this is invalid and causes the machine to hang hard when a CPU
is offlined.

Use wfi macro instead of the hardcoded WFI instruction.
Is it possible to change it for cpu_do_idle() ?
Please let's not encourage every wfi() to be turned into cpu_do_idle().  
They are not always equivalent.  And semantically they are not.


Nicolas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help