[PATCH 02/11] pinctrl: sunxi: add IRQCHIP_SKIP_SET_WAKE flag for pinctrl irq chip
From: Hans de Goede <hidden>
Date: 2014-05-27 09:09:17
Also in:
linux-devicetree, linux-mmc, linux-wireless
Possibly related (same subject, not in this thread)
- 2014-05-28 · Re: [PATCH 02/11] pinctrl: sunxi: add IRQCHIP_SKIP_SET_WAKE flag for pinctrl irq chip · Tomasz Figa <hidden>
- 2014-05-28 · Re: [PATCH 02/11] pinctrl: sunxi: add IRQCHIP_SKIP_SET_WAKE flag for pinctrl irq chip · Maxime Ripard <hidden>
- 2014-05-26 · [PATCH 02/11] pinctrl: sunxi: add IRQCHIP_SKIP_SET_WAKE flag for pinctrl irq chip · Hans de Goede <hidden>
Hi, On 05/27/2014 10:07 AM, Maxime Ripard wrote:
On Mon, May 26, 2014 at 09:47:57AM +0200, Hans de Goede wrote:quoted
From: Chen-Yu Tsai <redacted> The sunxi pinctrl irq chip driver does not support wakeup at the moment. Adding IRQCHIP_SKIP_SET_WAKE lets the irqs work with drivers using wakeup. Also add a name to the irq chip. Signed-off-by: Chen-Yu Tsai <redacted> Signed-off-by: Hans de Goede <redacted> --- drivers/pinctrl/sunxi/pinctrl-sunxi.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c index db9ccd6..ec60c2e 100644 --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c@@ -646,6 +646,8 @@ static struct irq_chip sunxi_pinctrl_irq_chip = { .irq_mask_ack = sunxi_pinctrl_irq_mask_ack, .irq_unmask = sunxi_pinctrl_irq_unmask, .irq_set_type = sunxi_pinctrl_irq_set_type, + .name = "sunxi-pio", + .flags = IRQCHIP_SKIP_SET_WAKE,I'd rather see the name set to dev_name() or something like that. This will not work that great with multiple pin controller supporting interrupts.
That would require moving the irq_chip struct to become a member of the sunxi_pinctrl struct. Not undoable, but that seems like something which should be done in a separate patch. So shall I just drop the .name part of this patch for now ? Regards, Hans