On Fri, May 16, 2014 at 8:03 PM, Feng Kan [off-list ref] wrote:

Add gpio dts node for APM X-Gene SoC platform.

Signed-off-by: Feng Kan <redacted>

(...)

+               gpio: gpio at 1701c000 {
+                       compatible = "apm,xgene-gpio";
+                       reg = <0x0 0x1701c000 0x0 0x1000>;
+
+                       banka: gpio-controller at 0 {
+                               compatible = "apm,xgene-gpio-port";
+                               gpio-controller;
+                               #gpio-cells = <2>;
+                               ngpios = <16>;
+                               bank = <0>;
+                       };
+                       bankb: gpio-controller at 1 {
+                               compatible = "apm,xgene-gpio-port";
+                               gpio-controller;
+                               #gpio-cells = <2>;
+                               ngpios = <16>;
+                               bank = <1>;
+                       };
+                       bankc: gpio-controller at 2 {
+                               compatible = "apm,xgene-gpio-port";
+                               gpio-controller;
+                               #gpio-cells = <2>;
+                               ngpios = <16>;
+                               bank = <2>;
+                       };
+               };

NAK, please construct this with one gpio per bank and
three independent entries instead of sub-banks.

Yours,
Linus Walleij