Thread (1 message) 1 message, 1 author, 2014-05-14

[PATCH v13 2/2] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

From: Hans de Goede <hidden>
Date: 2014-05-14 12:06:34
Also in: linux-devicetree, linux-mmc

Hi,

On 05/14/2014 02:03 PM, Ulf Hansson wrote:
On 12 May 2014 15:00, Arend van Spriel [off-list ref] wrote:
quoted
On 05/12/2014 02:04 PM, Hans de Goede wrote:
quoted
From: David Lanzend?rfer<redacted>

The Allwinner sunxi mmc host uses dma in bus-master mode using a built-in
designware idmac controller, which is identical to the one found in the
mmc-dw
hosts. However the rest of the host is not identical to mmc-dw, it deals
with
sending stop commands in hardware which makes it significantly different
from the mmc-dw devices.

HdG: Various cleanups and fixes.

Just nitpicking, but usually the above line should be added below the
original signoff, so:
quoted
Signed-off-by: David Lanzend?rfer<redacted>
[hdegoede at redhat.com: various cleanups and fixes]
quoted
Signed-off-by: Hans de Goede<redacted>

As is documented in SubmittingPatches.

Gr. AvS

This looks good to me, thanks Hans!

I will include this in the next PR I send to Chris, I will also take
the liberty to fixup the commit msg as pointed out by Arend.
Great, thanks!

Regards,

Hans
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help