Thread (1 message) 1 message, 1 author, 2014-05-08
DORMANTno replies

[PATCH 1/4] edac: Fix MC scrub mode comparsion bug for correctable error

From: Loc Ho <hidden>
Date: 2014-05-08 23:03:16
Also in: linux-devicetree
Subsystem: edac-core, the rest · Maintainers: Borislav Petkov, Tony Luck, Linus Torvalds

Possibly related (same subject, not in this thread)

This patch fixes the MC scrub mode comparsion bug by replacing
'&' with '=='. The MC structure field scrub_mode is integer
type - not bit field.

Signed-off-by: Loc Ho <redacted>
---
 drivers/edac/edac_mc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
index 33edd67..2c694b5 100644
--- a/drivers/edac/edac_mc.c
+++ b/drivers/edac/edac_mc.c
@@ -1018,7 +1018,7 @@ static void edac_ce_error(struct mem_ctl_info *mci,
 	}
 	edac_inc_ce_error(mci, enable_per_layer_report, pos, error_count);
 
-	if (mci->scrub_mode & SCRUB_SW_SRC) {
+	if (mci->scrub_mode == SCRUB_SW_SRC) {
 		/*
 			* Some memory controllers (called MCs below) can remap
 			* memory so that it is still available at a different
-- 
1.5.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help