[PATCH v4 05/15] clk: exynos5420: update clocks for G2D and G3D blocks
From: Tomasz Figa <hidden>
Date: 2014-05-06 16:50:13
Also in:
linux-devicetree, linux-samsung-soc
Hi Shaik, On 06.05.2014 18:26, Shaik Ameer Basha wrote:
quoted hunk ↗ jump to hunk
This patch adds missing clocks of G2D block. It also removes the aclkg3d alias from G3D block clocks. Signed-off-by: Rahul Sharma <redacted> Signed-off-by: Shaik Ameer Basha <redacted> --- drivers/clk/samsung/clk-exynos5420.c | 17 ++++++++++++++--- include/dt-bindings/clock/exynos5420.h | 2 ++ 2 files changed, 16 insertions(+), 3 deletions(-)diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c index 320f72d..5bc4798 100644 --- a/drivers/clk/samsung/clk-exynos5420.c +++ b/drivers/clk/samsung/clk-exynos5420.c@@ -27,6 +27,7 @@ #define DIV_CPU1 0x504 #define GATE_BUS_CPU 0x700 #define GATE_SCLK_CPU 0x800 +#define GATE_IP_G2D 0x8800 #define CPLL_LOCK 0x10020 #define DPLL_LOCK 0x10030 #define EPLL_LOCK 0x10040@@ -402,8 +403,8 @@ static struct samsung_mux_clock exynos5420_mux_clks[] __initdata = { 8, 1), MUX(0, "mout_user_aclk266_g2d", mout_user_aclk266_g2d_p, SRC_TOP5, 12, 1), - MUX_A(CLK_MOUT_G3D, "mout_user_aclk_g3d", mout_user_aclk_g3d_p, - SRC_TOP5, 16, 1, "aclkg3d"), + MUX(CLK_MOUT_G3D, "mout_user_aclk_g3d", mout_user_aclk_g3d_p, + SRC_TOP5, 16, 1), MUX(0, "mout_user_aclk300_jpeg", mout_user_aclk300_jpeg_p, SRC_TOP5, 20, 1), MUX(0, "mout_user_aclk300_disp1", mout_user_aclk300_disp1_p,@@ -830,6 +831,16 @@ static struct samsung_gate_clock exynos5420_gate_clks[] __initdata = { GATE(CLK_SMMU_FIMD1, "smmu_fimd1", "aclk300_disp1", GATE_IP_DISP1, 8, 0, 0), + /* G2D */ + GATE(CLK_MDMA0, "mdma0", "aclk266_g2d", + GATE_IP_G2D, 1, CLK_IGNORE_UNUSED, 0), + GATE(CLK_G2D, "g2d", "aclk333_g2d", + GATE_IP_G2D, 3, CLK_IGNORE_UNUSED, 0), + GATE(CLK_SMMU_MDMA0, "smmu_mdma0", "aclk266_g2d", + GATE_IP_G2D, 5, CLK_IGNORE_UNUSED, 0), + GATE(CLK_SMMU_G2D, "smmu_g2d", "aclk333_g2d", + GATE_IP_G2D, 7, CLK_IGNORE_UNUSED, 0),
Why they all have CLK_IGNORE_UNUSED flag set? This isn't very good from power management point of view. Sorry for commenting on this only in this version of the series, but I was a bit short of time before. I'll try to review this one thoroughly. Best regards, Tomasz