Thread (28 messages) 28 messages, 8 authors, 2014-06-03

[PATCH] of: treat PCI config space as IORESOURCE_MEM type

From: Rob Herring <hidden>
Date: 2014-05-29 20:44:52
Also in: linux-arm-msm, linux-devicetree, linux-pci, lkml

On Thu, May 29, 2014 at 11:03 AM, Kumar Gala [off-list ref] wrote:
If we have a PCI config space specified in something like a ranges
property we should treat it as memory type resource.
Config space should not be in ranges[1]. We have some cases that are,
but we don't want new ones.
quoted hunk ↗ jump to hunk
Signed-off-by: Kumar Gala <redacted>
---
 drivers/of/address.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/of/address.c b/drivers/of/address.c
index cb4242a..4e7ee59 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -122,6 +122,9 @@ static unsigned int of_bus_pci_get_flags(const __be32 *addr)
        u32 w = be32_to_cpup(addr);

        switch((w >> 24) & 0x03) {
+       case 0x00: /* cfg space */
+               flags |= IORESOURCE_MEM;
+               break;
How would you then distinguish actual memory ranges?

Rob

[1] http://www.spinics.net/lists/linux-pci/msg30585.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help