Thread (17 messages) flat view 17 messages, 2 authors, 2014-05-22

[PATCH 09/10] mtd: st_spi_fsm: Provide mask to obtain correct boot device pins

From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-05-22 11:47:45
Also in: lkml

On Thursday 22 May 2014 12:24:07 Lee Jones wrote:
+       /* Mask to apply on boot_device_reg */
+       ret = of_property_read_u32(np, "st,boot-device-msk", &boot_device_msk);
+       if (ret)
+               goto boot_device_fail;
+
The binding defines this property as "optional", but the driver fails
here if it's not provided. I suggest you add a default value here so you
can deal with existing dts. The default should be documented in
the binding as well.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help