Hi Olof,

On 05/20/2014 08:18 AM, Olof Johansson wrote:

Hi,

Just a quick drive-by review since I was looking at these patches in
the pull request you sent.

Thanks for the review.
I will send a new series taking your comments into account, except the 
one about reference-based syntax.

[...]

quoted

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 12455cf..f760a88 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile

@@ -317,7 +317,8 @@ dtb-$(CONFIG_ARCH_SPEAR6XX)+= spear600-evb.dtb
  dtb-$(CONFIG_ARCH_STI)+= stih415-b2000.dtb \
         stih416-b2000.dtb \
         stih415-b2020.dtb \
-       stih416-b2020.dtb
+       stih416-b2020.dtb \
+       stih407-b2120.dtb

These should be in alphanumerical order. 407 comes before 415. You've
been out of order with others as well.

Ok, it will be re-ordered in the next series.

quoted

  dtb-$(CONFIG_ARCH_SUNXI) += \
         sun4i-a10-a1000.dtb \
         sun4i-a10-cubieboard.dtb \

diff --git a/arch/arm/boot/dts/stih407-b2120.dts b/arch/arm/boot/dts/stih407-b2120.dts
new file mode 100644
index 0000000..9c97da4
--- /dev/null
+++ b/arch/arm/boot/dts/stih407-b2120.dts

@@ -0,0 +1,78 @@
+/*
+ * Copyright (C) 2014 STMicroelectronics (R&D) Limited.
+ * Author: Giuseppe Cavallaro <peppe.cavallaro@st.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+#include "stih407.dtsi"
+/ {
+       model = "STiH407 B2120";
+       compatible = "st,stih407", "st,stih407-b2120";

This should go from specific to generic, so the order needs to be the other way.

Please check other dts files for the same (I didn't).

Ok, I will change that for this dts and also the other ones.
Thanks,
Maxime