Thread (30 messages) 30 messages, 7 authors, 2014-06-10

[PATCH v5 5/6] exynos: cpuidle: do not allow cpuidle registration for Exynos5420

From: Chander Kashyap <hidden>
Date: 2014-05-16 04:01:41
Also in: linux-pm, linux-samsung-soc, lkml

Hi Tomasz,

On 16 May 2014 02:56, Tomasz Figa [off-list ref] wrote:
Hi Chander,

On 14.05.2014 10:03, Chander Kashyap wrote:
quoted
Exynos5420 is big.Little Soc. It uses cpuidle-big-litle generic cpuidle driver.
Hence do not allow exynos cpuidle driver registration for Exynos5420.

Signed-off-by: Chander Kashyap <redacted>
Signed-off-by: Chander Kashyap <redacted>
Acked-by: Daniel Lezcano <redacted>
---
 arch/arm/mach-exynos/cpuidle.c |    3 +++
 1 file changed, 3 insertions(+)
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c
index 3dd385e..807a386 100644
--- a/arch/arm/mach-exynos/cpuidle.c
+++ b/arch/arm/mach-exynos/cpuidle.c
@@ -218,6 +218,9 @@ static int exynos_cpuidle_probe(struct platform_device *pdev)
      int cpu_id, ret;
      struct cpuidle_device *device;

+     if (soc_is_exynos5420())
+             return -ENODEV;
+
      if (soc_is_exynos5250())
              exynos5_core_down_clk();
Why not put this in exynos.c in exynos_dt_machine_init(), so
exynos_cpuidle_init() is called only if not running on Exynos5420?
That makes more sense.
I will update this

Thanks
Best regards,
Tomasz


-- 
with warm regards,
Chander Kashyap
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help