[PATCH v5 9/9] ARM: koelsch: Add HAVE_ARM_ARCH_TIMER to defconfig
From: magnus.damm@gmail.com (Magnus Damm)
Date: 2014-03-26 05:39:06
Also in:
linux-pci, linux-sh
On Wed, Mar 26, 2014 at 1:56 AM, Phil Edworthy [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This is fixes a boot problem when the R-Car PCIe driver is enabled. Signed-off-by: Phil Edworthy <redacted> --- arch/arm/configs/koelsch_defconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/arm/configs/koelsch_defconfig b/arch/arm/configs/koelsch_defconfig index ec14547..67666b6 100644 --- a/arch/arm/configs/koelsch_defconfig +++ b/arch/arm/configs/koelsch_defconfig@@ -15,6 +15,7 @@ CONFIG_MACH_KOELSCH=y CONFIG_CPU_BPREDICT_DISABLE=y CONFIG_PL310_ERRATA_588369=y CONFIG_ARM_ERRATA_754322=y +CONFIG_HAVE_ARM_ARCH_TIMER=y
Hi Phil, Thanks for your patches! I appreciate that you send out a whole series with broken out patches, that makes it easier to see what is going on. However, regarding this particular patch I'm not so sure if your fix is correct. The issue is most likely there, no doubt about that, but this "select" does not match well with how we currently handle timers for the rest of the SoCs in mach-shmobile. We for instance want to be able to boot with CMT only. So here's a gentle "NAK" on this particular patch. I think this shows that either deferred probing or a different init ordering is needed somehow. Thanks, / magnus