On Sat, Mar 22, 2014 at 07:13:36PM +0100, Carlo Caione wrote:

On Sat, Mar 22, 2014 at 6:33 PM, Mark Brown [off-list ref] wrote:

quoted

On Sat, Mar 22, 2014 at 05:51:32PM +0100, Carlo Caione wrote:

quoted

On Tue, Mar 18, 2014 at 03:59:19PM +0000, Lee Jones wrote:

quoted

quoted

quoted

+ of_id = of_match_device(axp20x_of_match, &i2c->dev);
+ if (!of_id) {
+         dev_err(&i2c->dev, "Unable to setup AXP20X data\n");
+         return -ENODEV;
+ }
+ axp20x->variant = (int) of_id->data;

quoted

quoted

No need to cast from void *.

quoted

My compiler says otherwise :)

Are you sure your compiler isn't correctly telling you not to cast away
const?  If the compiler is complaining about a cast on void then it's
spotted a definite bug.

[resend since gmail decided to not put broonie in CC]

drivers/mfd/axp20x.c:172:18: warning: assignment makes integer
frompointer without a cast [enabled by default]

You need to cast to long, otherwise you will get warnings when compiling
on 64 bit arches.

Thanks.

-- 
Dmitry