[PATCH v2 5/8] regulator: AXP20x: Add support for regulators subsystem
From: broonie@kernel.org (Mark Brown)
Date: 2014-03-17 17:33:07
Also in:
linux-devicetree, linux-input
Possibly related (same subject, not in this thread)
- 2014-03-17 · Re: [PATCH v2 5/8] regulator: AXP20x: Add support for regulators subsystem · Krzysztof Kozlowski <hidden>
- 2014-03-15 · [PATCH v2 5/8] regulator: AXP20x: Add support for regulators subsystem · Carlo Caione <hidden>
On Sat, Mar 15, 2014 at 04:43:42PM +0100, Carlo Caione wrote:
AXP202 and AXP209 come with two synchronous step-down DC-DCs and five LDOs. This patch introduces basic support for those regulators.
This is mostly fine apart from the things Krzysztof mentioned and...
+static int axp20x_set_dcdc_freq(struct platform_device *pdev, u32 dcdcfreq)
+{
+ struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent);
+
+ if (dcdcfreq < 750)
+ dcdcfreq = 750;
+
+ if (dcdcfreq > 1875)
+ dcdcfreq = 1875;I'd expect at least a warning on out of spec values being specified here. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140317/d64f3f99/attachment.sig>