Re: [PATCH] ahci_imx: Put #ifdef CONFIG_PM_SLEEP around suspend / resume functions
From: Alexander Shiyan <hidden>
Date: 2014-03-05 19:27:45
Also in:
linux-devicetree, linux-ide
Possibly related (same subject, not in this thread)
- 2014-03-06 · Re: [PATCH] ahci_imx: Put #ifdef CONFIG_PM_SLEEP around suspend / resume functions · Tejun Heo <hidden>
- 2014-03-05 · [PATCH] ahci_imx: Put #ifdef CONFIG_PM_SLEEP around suspend / resume functions · Hans de Goede <hidden>
?????, 5 ????? 2014, 20:23 +01:00 ?? Marek Vasut [off-list ref]:
On Wednesday, March 05, 2014 at 08:17:49 PM, Hans de Goede wrote:quoted
This fixes the following warnings when CONFIG_PM_SLEEP is not set: drivers/ata/ahci_imx.c:284:12: warning: ?imx_ahci_suspend? defined but not used [-Wunused-function] drivers/ata/ahci_imx.c:299:12: warning: ?imx_ahci_resume? defined but not used [-Wunused-function] Reported-by: Bartlomiej Zolnierkiewicz <redacted> Cc: Bartlomiej Zolnierkiewicz <redacted> Signed-off-by: Hans de Goede <redacted>Obviously makes sense. Acked-by: Marek Vasut <marex@denx.de>
But a better way is to use the "__maybe_unused" attribute for such cases. ---