Thread (1 message) 1 message, 1 author, 2014-03-04

[PATCH 3/3] ARM: Kirkwood: DT: Add missing vendor prefix

From: andrew@lunn.ch (Andrew Lunn)
Date: 2014-03-04 09:28:54
Also in: linux-devicetree

On Mon, Mar 03, 2014 at 10:05:22PM -0500, Jason Cooper wrote:
Andrew,

Couple of stupid questions:

 - I haven't seen 0/1 nor 1/1 show up anywhere (dt, lakml, inbox), am I
   missing something?
Humm, i will check, and do a resend if needed.

 
On Sun, Mar 02, 2014 at 04:24:15PM +0100, Andrew Lunn wrote:
quoted
Add vendor prefixes to compatible strings where they are missing.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 arch/arm/boot/dts/kirkwood-b3.dts              | 2 +-
 arch/arm/boot/dts/kirkwood-cloudbox.dts        | 2 +-
 arch/arm/boot/dts/kirkwood-dreamplug.dts       | 2 +-
 arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 2 +-
 arch/arm/boot/dts/kirkwood-ns2-common.dtsi     | 2 +-
 arch/arm/boot/dts/kirkwood-nsa310.dts          | 2 +-
 arch/arm/boot/dts/kirkwood-nsa310a.dts         | 2 +-
 arch/arm/boot/dts/kirkwood-openblocks_a6.dts   | 2 +-
 arch/arm/boot/dts/kirkwood-openblocks_a7.dts   | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/kirkwood-b3.dts b/arch/arm/boot/dts/kirkwood-b3.dts
index 40791053106b..6becedebaa4e 100644
--- a/arch/arm/boot/dts/kirkwood-b3.dts
+++ b/arch/arm/boot/dts/kirkwood-b3.dts
@@ -75,7 +75,7 @@
 			m25p16 at 0 {
 				#address-cells = <1>;
 				#size-cells = <1>;
-				compatible = "m25p16";
+				compatible = "st,m25p16";
Have you checked that the drivers for each of these changes already
support the new compatible strings?
I2c and MTD ignore the vendor string when performing matches. However,
checkpatch.pl does not. It is also technically correct to have a
vendor string.

       Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help