Thread (76 messages) 76 messages, 10 authors, 2014-07-08

[PATCH v7 2/6] pci: OF: Fix the conversion of IO ranges into IO resources.

flat view

From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-03-14 17:06:14
Also in: linux-devicetree, linux-pci, lkml

On Friday 14 March 2014, Liviu Dudau wrote:
quoted hunk ↗ jump to hunk
+int of_pci_range_to_resource(struct of_pci_range *range,
+       struct device_node *np, struct resource *res)
+{
+       res->flags = range->flags;
+       if (res->flags & IORESOURCE_IO) {
+               unsigned long port = -1;
+               int err = pci_register_io_range(range->cpu_addr, range->size);
+               if (err)
+                       return err;
+               port = pci_address_to_pio(range->cpu_addr);
+               if (port == (unsigned long)-1) {
+                       res->start = (resource_size_t)OF_BAD_ADDR;
+                       res->end = (resource_size_t)OF_BAD_ADDR;
+                       return -EINVAL;
+               }
The error handling is inconsistent here: in one case you set the resource
to OF_BAD_ADDR, in the other one you don't.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help