[PATCH v4 6/7] DMA: sun6i: Add driver for the Allwinner A31 DMA controller
From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-03-10 17:57:48
Also in:
linux-devicetree, lkml
From: arnd@arndb.de (Arnd Bergmann)
Date: 2014-03-10 17:57:48
Also in:
linux-devicetree, lkml
On Monday 10 March 2014 17:51:56 Maxime Ripard wrote:
quoted
Neither "pll6" nor "ahb1_mux" are listed in the DT binding. Also, why is it the driver's business to set the parent?Those are global clocks, so it's not really part pof the driver binding itself. But I can add them.
No better don't then. Can you change the clk_get() call to pass NULL as the device pointer to clarify this in the source though?
About the reparenting itself, other devices are actually fine having any parent they want, only the DMA is picky about it (at least, from what we know), so it made sense to me to put it into the driver itself. Where would you put it?
Maybe Mike Turquette has an idea. We have in the past discussed about cases where you want the default clock setting to be part of the clock provider in some property. Could that work here? Arnd