On Thursday 06 March 2014, Liviu Dudau wrote:

On Tue, Mar 04, 2014 at 10:28:51PM +0000, Arnd Bergmann wrote:

quoted

On Tuesday 04 March 2014, Liviu Dudau wrote:

quoted

+extern int isa_dma_bridge_buggy;

As commented before, I still think we can hardcode this to off

Unfortunately that doesn't work when you have CONFIG_PCI=y. drivers/pci/pci.c has:

drivers/pci/pci.c:int isa_dma_bridge_buggy;
drivers/pci/pci.c:EXPORT_SYMBOL(isa_dma_bridge_buggy);

and drivers/pci/quirks.c does:

drivers/pci/quirks.c:   if (!isa_dma_bridge_buggy) {
drivers/pci/quirks.c:           isa_dma_bridge_buggy=1;
drivers/pci/quirks.c-           dev_info(&dev->dev, "Activating ISA DMA hang workarounds\n");
drivers/pci/quirks.c-   }

Ah, I see. Should we maybe move the declaration to a more generic header
file then? If the architectures cannot override it anyway, it shouldn't
be up to the architecture to declare it.

	Arnd