[PATCH v5 7/7] pci: Add support for creating a generic host_bridge from device tree
From: Liviu Dudau <hidden>
Date: 2014-03-05 08:35:07
Also in:
linux-devicetree, linux-pci, lkml
On Wed, Mar 05, 2014 at 10:20:28AM +0900, Jingoo Han wrote:
quoted hunk ↗ jump to hunk
On Wednesday, March 05, 2014 12:50 AM, Liviu Dudau wrote:quoted
Several platforms use a rather generic version of parsing the device tree to find the host bridge ranges. Move the common code into the generic PCI code and use it to create a pci_host_bridge structure that can be used by arch code. Based on early attempts by Andrew Murray to unify the code. Used powerpc and microblaze PCI code as starting point. Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c index 8708b652..800678a 100644 --- a/drivers/pci/host-bridge.c +++ b/drivers/pci/host-bridge.c[.....]quoted
+ res = kzalloc(sizeof(struct resource), GFP_KERNEL);It makes build error with exynos_defconfig. (ARM32) Thus, 'slab.h' is necessary in order to fix the build error. ./drivers/pci/host-bridge.c@@ -8,6 +8,7 @@ #include <linux/module.h> #include <linux/of_address.h> #include <linux/of_pci.h> +#include <linux/slab.h>
Will add, thanks!
#include "pci.h"quoted
+ if (!res) { + err = -ENOMEM; + goto bridge_ranges_nomem; + } + + of_pci_range_to_resource(&range, dev, res); + + if (resource_type(res) == IORESOURCE_IO) + *io_base = range.cpu_addr; + + pci_add_resource_offset(resources, res, + res->start - range.pci_addr); + } + + /* Apply architecture specific fixups for the ranges */ + pcibios_fixup_bridge_ranges(resources);It also makes compile problem with exynos_defconfig as below: drivers/built-in.o: In function `pci_host_bridge_of_get_ranges': drivers/pci/host-bridge.c:157: undefined reference to `pcibios_fixup_bridge_ranges'
Does that mean that exynos_defconfig doesn't define CONFIG_OF? How do you compile all the .dts files then? Should CONFIG_OF not be added to the default config file? Other than that, your comment is correct. drivers/pci/host-bridge.c gets compiled in regardless of CONFIG_OF and I need to provide an empty implementation for pcibios_fixup_bridge_ranges(). Thanks! Liviu
Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--
-------------------
.oooO
( )
\ ( Oooo.
\_) ( )
) /
(_/
One small step
for me ...