Thread (41 messages) 41 messages, 10 authors, 2014-02-20
STALE4488d

[PATCH v2 01/19] serial: sh-sci: Enable the driver on all ARM platforms

From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
Date: 2014-02-19 22:24:38
Also in: linux-serial, linux-sh

Hi Uwe,

On Wednesday 19 February 2014 21:54:46 Uwe Kleine-K?nig wrote:
On Tue, Oct 29, 2013 at 11:37:36PM +0100, Laurent Pinchart wrote:
quoted
Renesas ARM platforms are transitioning from single-platform to
multi-platform kernels using the new ARCH_SHMOBILE_MULTI. Make the
driver available on all ARM platforms to enable it on both ARCH_SHMOBILE
and ARCH_SHMOBILE_MULTI, and increase build testing coverage with
COMPILE_TEST.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial at vger.kernel.org
Signed-off-by: Laurent Pinchart
[off-list ref]
---

 drivers/tty/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index febd45c..9a5a8ef 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -709,7 +709,7 @@ config SERIAL_IP22_ZILOG_CONSOLE

 config SERIAL_SH_SCI
 
 	tristate "SuperH SCI(F) serial port support"

-	depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE)
+	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)

 	select SERIAL_CORE
This patch is in mainline as d4f9e7b3d12e92ede642f6f4fc7d959f06da8ccc
since v3.13-rc1. I wonder if

	depends on HAVE_CLK && (SUPERH || ARCH_SHMOBILE || COMPILE_TEST)

isn't the better option. (Since bf98c1eac1d4a6bcf00532e4fa41d8126cd6c187
ARCH_SHMOBILE is enabled for both multi-platform and legacy shmobile
configs.) Or do you plan to deprecate ARCH_SHMOBILE?
We don't plan to deprecate ARCH_SHMOBILE. I've posted a patch to fix this, 
please see http://www.spinics.net/lists/linux-sh/msg28296.html ("[PATCH 1/2] 
serial: sh-sci: Restrict non-COMPILE_TEST compilation").

-- 
Regards,

Laurent Pinchart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help