Thread (7 messages) flat view 7 messages, 2 authors, 2014-02-19
STALE4567d

Revision v1 of 5 in this series.

Revisions (5)
  1. v1 [diff vs current]
  2. v1 current
  3. v1 [diff vs current]
  4. v1 [diff vs current]
  5. v2 [diff vs current]

[PATCH 2/2] ARM: DTS: OMAP4: Add gpmc_fck clock node

From: Tero Kristo <hidden>
Date: 2014-02-17 12:29:45
Also in: linux-omap

On 02/17/2014 01:27 PM, Florian Vaussard wrote:
quoted hunk ↗ jump to hunk
Add the gpmc_fck clock, derived from l3_ick, and reference it from
the GPMC node to get it correctly working.

Signed-off-by: Florian Vaussard <redacted>
---
  arch/arm/boot/dts/omap4.dtsi           | 2 ++
  arch/arm/boot/dts/omap44xx-clocks.dtsi | 6 ++++++
  2 files changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index d3f8a6e..8a0cc71 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -275,6 +275,8 @@
  			gpmc,num-waitpins = <4>;
  			ti,hwmods = "gpmc";
  			ti,no-idle-on-init;
+			clocks = <&gpmc_fck>;
+			clock-names = "fck";
  		};

  		uart1: serial at 4806a000 {
diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi b/arch/arm/boot/dts/omap44xx-clocks.dtsi
index c821ff5..ae2c441 100644
--- a/arch/arm/boot/dts/omap44xx-clocks.dtsi
+++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi
@@ -1036,6 +1036,12 @@
  		ti,index-power-of-two;
  	};

+	gpmc_fck: gpmc_fck {
+		#clock-cells = <0>;
+		compatible = "ti,clkdm-gate-clock";
+		clocks = <&l3_div_ck>;
+	};
+
Why not implement a proper gate clock for CM_L3_2_GPMC_CLKCTRL? The 
approach you have taken looks good to me otherwise.

-Tero
  	gpio2_dbclk: gpio2_dbclk {
  		#clock-cells = <0>;
  		compatible = "ti,gate-clock";
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help