[PATCH] dcp: aes: Move the AES operation type from actx to rctx
From: herbert@gondor.apana.org.au (Herbert Xu)
Date: 2014-02-09 09:19:59
Also in:
linux-crypto
On Tue, Jan 14, 2014 at 06:31:01PM +0100, Marek Vasut wrote:
Move the AES operation type and mode from async crypto context to crypto request context. This allows for recycling of the async crypto context for different kinds of operations. I found this problem when I used dm-crypt, which uses the same async crypto context (actx) for both encryption and decryption requests. Since the requests are enqueued into the processing queue, immediatelly storing the type of operation into async crypto context (actx) caused corruption of this information when encryption and decryption operations followed imediatelly one after the other. When the first operation was dequeued, the second operation was already enqueued and overwritten the type of operation in actx, thus causing incorrect result of the first operation. Fix this problem by storing the type of operation into the crypto request context. Signed-off-by: Marek Vasut <marex@denx.de> Cc: David S. Miller <davem@davemloft.net> Cc: Fabio Estevam <redacted> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: Shawn Guo <redacted> Cc: Tom Lendacky <thomas.lendacky@amd.com>
Patch applied. -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt