Thread (1 message) 1 message, 1 author, 2014-02-19

[PATCH v3 1/4] Phytec phyFLEX-i.MX6 : Added USB_OTG Support

From: Shawn Guo <hidden>
Date: 2014-02-19 05:58:29
Also in: linux-devicetree

On Wed, Feb 19, 2014 at 10:23:09AM +0800, Shawn Guo wrote:
quoted
@@ -18,6 +18,14 @@
 	memory {
 		reg = <0x10000000 0x80000000>;
 	};
+
+	reg_usb_otg_vbus: regulator at 0 {
You do not have a 'reg' property in the node, so you shouldn't have
'@num' in node name.  You may want to name it 'regulator-0'.
I just saw the talk between Stephen and Mark [1], and I'm with Stephen
that neither regulator-0 nor regulator_0 is a good name.  Since Mark is
giving up the argument on the container, please follow the way we do in
other IMX dts today.

Shawn

[1] http://thread.gmane.org/gmane.linux.drivers.devicetree/61894/focus=62405
quoted
+		compatible = "regulator-fixed";
+		regulator-name = "usb_otg_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio4 15 0>;
+	};
 };
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help